Skip to content

chore(scripts): remove double error log #1366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 2, 2023
Merged

chore(scripts): remove double error log #1366

merged 1 commit into from
Mar 2, 2023

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Mar 2, 2023

🧭 What and Why

When an error occurs in execa we printed the error twice, there is no need for that and we can print a better error instead.

@millotp millotp self-assigned this Mar 2, 2023
@millotp millotp requested a review from a team as a code owner March 2, 2023 10:25
@millotp millotp requested review from damcou and Fluf22 and removed request for a team March 2, 2023 10:25
@netlify
Copy link

netlify bot commented Mar 2, 2023 •
edited
Loading

✅ Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit 979106a
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/64008ad7c4ce9200080d7e1e
😎 Deploy Preview https://deploy-preview-1366--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Mar 2, 2023 •
edited
Loading

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

Fluf22
Fluf22 previously approved these changes Mar 2, 2023
View reviewed changes
Copy link
Contributor

@Fluf22 Fluf22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌🏻

shortcuts
shortcuts previously approved these changes Mar 2, 2023
View reviewed changes
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YES TY

Base automatically changed from chore/use-spinnies to main March 2, 2023 11:38
@millotp millotp dismissed stale reviews from shortcuts and Fluf22 via 979106a March 2, 2023 11:39
@millotp millotp force-pushed the chore/double-log branch from 5863a15 to 979106a Compare March 2, 2023 11:39
@millotp millotp requested review from Fluf22 and shortcuts March 2, 2023 11:39
@millotp millotp enabled auto-merge (squash) March 2, 2023 11:40
@millotp millotp disabled auto-merge March 2, 2023 11:41
@millotp millotp merged commit 87a7dee into main Mar 2, 2023
@millotp millotp deleted the chore/double-log branch March 2, 2023 11:41
@millotp millotp mentioned this pull request Mar 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damcou damcou Awaiting requested review from damcou damcou is a code owner automatically assigned from algolia/api-clients-automation

@Fluf22 Fluf22 Awaiting requested review from Fluf22

@shortcuts shortcuts Awaiting requested review from shortcuts

Assignees

@millotp millotp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@millotp @algolia-bot @Fluf22 @shortcuts