fix(java): delete tag before release #1370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for api-clients-automation ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
shortcuts
previously approved these changes
Mar 3, 2023
| @@ -154,6 +151,7 @@ async function spreadGeneration(): Promise<void> { | |||
| `Processing release commit, creating new release tag ('${version}') for '${lang}' repository.` | |||
| ); | |||
|
|
|||
| await run(`git tag -d ${version}`, { cwd: tempGitDir }); | |||
There was a problem hiding this comment.
have you checking locally that deleting a non existing tag doesn't exit 1?
| @@ -459,6 +460,9 @@ async function createReleasePR(): Promise<void> { | |||
| await run(`CI=false git commit -m "${commitMessage}"`); | |||
| } | |||
|
|
|||
| // cleanup all the changes to the generated files (the ones not commited because of the pre-commit hook) | |||
| await run(`git checkout .`); | |||
shortcuts
approved these changes
Mar 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
Refacto some functions to put them in the right common file and avoid importing between folders.
Fix the java release by deleting the tag before the release