Skip to content

chore(dart): use melos to publish packages #1786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 20, 2023
Merged

Conversation

aallam
Copy link
Member

@aallam aallam commented Jul 20, 2023

🧭 What and Why

Each package is published individually, which can pose a problem in cases of dependency between versions (since we currently use exact versions).

Changes Included:

Use melos publish to automatically publish all packages.

@aallam aallam added the Dart Issue related to the Dart client label Jul 20, 2023
@aallam aallam requested a review from a team as a code owner July 20, 2023 07:54
@aallam aallam requested review from Fluf22 and shortcuts July 20, 2023 07:54
@netlify
Copy link

netlify bot commented Jul 20, 2023

Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit d56a426
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/64b8fcc497b9480008f8c023
😎 Deploy Preview https://deploy-preview-1786--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Jul 20, 2023

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice !


publish_algoliasearch:
publish:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it make sense to merge all 3 jobs in the same one and just use more steps ? I feel like having a full job just to compute the version is a bit overkill, and because all jobs depends on each other it could work well in a single flow.
Anyway just rumbling it works fine like this !

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is because the publish workflow uses a manual validation step

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh then that make sense

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've structured it this way to prevent the repository from making a publish commit when there is nothing to publish. If such a scenario is impossible, then we can certainly eliminate this logic!

@aallam aallam enabled auto-merge (squash) July 20, 2023 09:22
@aallam aallam merged commit 3ff73cf into main Jul 20, 2023
@aallam aallam deleted the fix/dart-publish-melos branch July 20, 2023 09:30
algolia-bot added a commit to algolia/algoliasearch-client-dart that referenced this pull request Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dart Issue related to the Dart client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants