-
Notifications
You must be signed in to change notification settings - Fork 21
chore(dart): use melos to publish packages #1786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for api-clients-automation ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice !
|
||
publish_algoliasearch: | ||
publish: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would it make sense to merge all 3 jobs in the same one and just use more steps ? I feel like having a full job just to compute the version is a bit overkill, and because all jobs depends on each other it could work well in a single flow.
Anyway just rumbling it works fine like this !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is because the publish workflow uses a manual validation step
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ahh then that make sense
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've structured it this way to prevent the repository from making a publish commit when there is nothing to publish. If such a scenario is impossible, then we can certainly eliminate this logic!
algolia/api-clients-automation#1786 Co-authored-by: Mouaad Aallam <[email protected]>
🧭 What and Why
Each package is published individually, which can pose a problem in cases of dependency between versions (since we currently use exact versions).
Changes Included:
Use
melos publish
to automatically publish all packages.