feat(dart): rely on common changelog #1788
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for api-clients-automation ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
|
do you want to make it retroactive @aallam |
We are still at alpha stage, we can just skip the old changelog content and start from new. |
true, I'll trigger a new release soon and delete previous content |
shortcuts
force-pushed
the
feat/dart-changelog
branch
from
9925163 to
04a92a0
Compare
millotp
approved these changes
Jul 20, 2023
| } | ||
|
|
||
| await updateChangelog(lang as Language, changelog[lang], current, next); | ||
| await updateChangelog( | ||
| lang as Language, |
There was a problem hiding this comment.
could be nice to use something like this to avoid the type conversion
|
will try it right away! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DI-1440
Changes included:
This PR aims at making Dart leverage the common changelog generation process, while still relying on Melos for version bump.
We now generate a changelog per Dart client, and omitting the changelog generation on the Melos side.
Things to fix:
currentVersionfrom the Dart packageHow to test:
LOCAL_TEST_DEV=trueto your.envfile at the root of the repoyarn docker:release