feat(scripts): allow subset release and major #3174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
morganleroi
approved these changes
Jun 13, 2024
millotp
reviewed
Jun 13, 2024
| @@ -200,4 +207,23 @@ program | |||
| await snippetsGenerateMany(generatorList({ language, client, clientList })); | |||
| }); | |||
|
|
|||
| program | |||
There was a problem hiding this comment.
could be really cool to have a dry run option for this one !
There was a problem hiding this comment.
true!! I'll add it in a subsequent pr
| const currentVersion = versions[lang].current; | ||
|
|
||
| if (!languages.includes(lang as Language)) { | ||
| console.log(`${lang} is not in the given language list, skipping release`); |
There was a problem hiding this comment.
I think this console log is interesting for debug mode, but in regular use it would be more interesting to log only the chosen languages
There was a problem hiding this comment.
the release script is pretty verbose which I believe is nice as it's a process that can fail in many ways :/ I'm fine with keeping the log, wdyt?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DI-2444
Changes included:
updates the release script to be able to only release a subset of clients, and also to promote that subset (or every) to the next major version
this will allow us to release the GA without introducing a breaking change commit, and also allows us to prevent bypassing
dartwhich is already stable.also moves the release script to the CLI script, makes more sense and allows leveraging the current logic