Skip to content

fix(scripts): add dry run release and fix major bump for python #3175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 13, 2024

Conversation

shortcuts
Copy link
Member

🧭 What and Why

🎟 JIRA Ticket: -

Changes included:

add dry run option for the release which allows testing the lts in a better manner
also fix pre-release bump for python versions, which is not semver compliant

@shortcuts shortcuts self-assigned this Jun 13, 2024
@shortcuts shortcuts requested a review from a team as a code owner June 13, 2024 13:44
@shortcuts shortcuts requested review from damcou and Fluf22 June 13, 2024 13:44
@algolia-bot
Copy link
Collaborator

algolia-bot commented Jun 13, 2024

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:kermittyping:

@@ -44,6 +44,8 @@ dotenv.config({ path: ROOT_ENV_PATH });

export const COMMON_SCOPES = ['specs', 'clients'];

const preReleaseRegExp = new RegExp(/\d\.\d\.\d(\.?a(lpha\.)?\d+|\.?b(eta\.)?\d+)$/);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:face_vomiting:

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahahah yes this one is pretty ugly I admit

@shortcuts shortcuts requested a review from millotp June 13, 2024 13:55
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gg !

@shortcuts shortcuts enabled auto-merge (squash) June 13, 2024 14:30
Copy link

@github-actions github-actions bot temporarily deployed to pull request June 13, 2024 14:36 Inactive
@shortcuts shortcuts merged commit c6629d0 into main Jun 13, 2024
25 checks passed
@shortcuts shortcuts deleted the feat/scripts-dry-run-and-major-python branch June 13, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants