Skip to content

feat(javascript): legacy getRecommendations signature #3241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

aymeric-giraudet
Copy link
Member

I tested the client with InstantSearch a little bit and some things don't work :

  • algoliasearch/lite does not have a default export
  • getRecommendations does not default threshold to 0 like it does in v4, this makes our current implem fail
  • Our client hydration logic in InstantSearch doesn't work as the transporter has baseHeaders and baseQueryParamaters rather than headers and queryParameters

@aymeric-giraudet aymeric-giraudet requested a review from a team as a code owner June 24, 2024 08:33
@aymeric-giraudet aymeric-giraudet requested review from Fluf22 and shortcuts and removed request for a team June 24, 2024 08:33
@algolia-bot
Copy link
Collaborator

algolia-bot commented Jun 24, 2024

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@aymeric-giraudet aymeric-giraudet marked this pull request as draft June 24, 2024 08:35
Base automatically changed from feat/algoliasearch-recommend to main June 24, 2024 08:55
@aymeric-giraudet aymeric-giraudet force-pushed the feat/getRecommendations-signature branch from 4241e49 to 075c775 Compare June 24, 2024 09:04
Copy link

github-actions bot commented Jun 24, 2024

@github-actions github-actions bot temporarily deployed to pull request June 24, 2024 09:19 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 24, 2024 09:48 Inactive
@aymeric-giraudet aymeric-giraudet force-pushed the feat/getRecommendations-signature branch from a8b667d to 8359f7f Compare June 24, 2024 11:01
@aymeric-giraudet aymeric-giraudet force-pushed the feat/getRecommendations-signature branch from 8592383 to 0fafa22 Compare June 24, 2024 11:09
@aymeric-giraudet aymeric-giraudet changed the title wip: legacy getRecommendations signature feat(javascript): legacy getRecommendations signature Jun 24, 2024
@aymeric-giraudet aymeric-giraudet marked this pull request as ready for review June 24, 2024 11:10
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful, waiting for the gen to see the output but nothing to add! Thanks :)

@github-actions github-actions bot temporarily deployed to pull request June 24, 2024 11:40 Inactive
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome thanks!!

@shortcuts shortcuts merged commit 632827b into main Jun 24, 2024
21 of 22 checks passed
@shortcuts shortcuts deleted the feat/getRecommendations-signature branch June 24, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants