Skip to content

chore(ci): remove gradle noise #3331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 9, 2024
Merged

chore(ci): remove gradle noise #3331

merged 5 commits into from
Jul 9, 2024

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Jul 8, 2024

🧭 What and Why

When using the tooling properly, with yarn cli or apic, there is no need for all the extra gradle files everywhere, which are not needed.

Make better use of the setup-gradle action to reuse the cache from the main branch but avoid recreating one per branch, and do the validation directly instead of using another action.

Also remove the custom yarn cache to try because it seems to be the exact same as the default action

Screenshot 2024-07-08 at 16 24 57

@millotp millotp requested a review from a team as a code owner July 8, 2024 14:25
@millotp millotp requested review from morganleroi and Fluf22 July 8, 2024 14:25
@millotp millotp self-assigned this Jul 8, 2024
@algolia-bot
Copy link
Collaborator

algolia-bot commented Jul 8, 2024

No code generated

If you believe code should've been generated, please, report the issue.

Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks huge

Copy link

github-actions bot commented Jul 8, 2024

Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so nice, playground still works right?

@millotp
Copy link
Collaborator Author

millotp commented Jul 9, 2024

so nice, playground still works right?

for java yes, I don't think it ever work for kotlin

@millotp millotp merged commit 3c57326 into main Jul 9, 2024
20 checks passed
@millotp millotp deleted the chore/gradle-cache branch July 9, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants