chore(cts): reuse method template #3385
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✔️ Code generated!
|
millotp
force-pushed
the
chore/simplify-client-tests
branch
from
b228a59 to
27bccc5
Compare
shortcuts
approved these changes
Jul 18, 2024
| @@ -29,7 +29,7 @@ export function assertValidTimeouts(expectedCount: number): void { | |||
| expect(state.duration[0] * 2).to.be.closeTo(state.duration[1], 200); | |||
| break; | |||
| case 'Swift': | |||
| expect(state.duration[0]).to.be.closeTo(state.duration[1], 500); | |||
| expect(state.duration[0]).to.be.closeTo(state.duration[1], 800); | |||
There was a problem hiding this comment.
Suggested change
| expect(state.duration[0]).to.be.closeTo(state.duration[1], 800); | |
| expect(state.duration[0]).to.be.closeTo(state.duration[1], 9000); |
let's preshot
| @@ -140,7 +140,7 @@ When writing your template, here is a list of variables accessible from `mustach | |||
| "method": "the method to call on the API Client", | |||
| "testName": "the descriptive name test (default to `method`)", | |||
| "testIndex": "the index of the test to avoid duplicate function name", | |||
| "hasParameters": "true if the method has parameters, useful for `GET` requests", | |||
| "hasParams": "true if the method has parameters, useful for `GET` requests", | |||
There was a problem hiding this comment.
makes me think we should use a json schema here instead of json
There was a problem hiding this comment.
yeah I can give it a try in another PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
We can reuse the
methodtemplate in all languages, and for all tests suites, instead of copy pasting it 4 times.Also simplify the logic and remove unused props, to make it more similar to the requests test suite