chore(cts): assert the retry strategy error #3405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✔️ Code generated!
📊 Benchmark resultsBenchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
|
morganleroi
previously approved these changes
Jul 22, 2024
shortcuts
reviewed
Jul 23, 2024
| "path": "1/test/hang/${{language}}" | ||
| }, | ||
| "expected": { | ||
| "error": { |
There was a problem hiding this comment.
if we add a new language, will this throw? I did not saw this specific case
There was a problem hiding this comment.
yes the CTS will add a default message and the test will fail, so its necessary to add it here
This was referenced Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
Suggested in #3334, we can add tests for the retry strategy error message, even if its different for every language.