chore(cts): report benchmark results #3406
Conversation
✔️ Code generated!
📊 Benchmark resultsBenchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
|
millotp
requested review from
morganleroi and
shortcuts
and removed request for
a team
| { | ||
| echo 'BENCHMARK_SECTION<<EOF' | ||
| echo "<details>" | ||
| echo "<summary>📊 Benchmark results</summary>" |
There was a problem hiding this comment.
can we add a small disclaimer like
take those results with a grain of salt, best effort benchmarking solution, in order to highlight general performances of our Search API
or something like that? just so people don't expect those to be a source of truth or things like that
There was a problem hiding this comment.
also we should mention that it's only tested on search?
There was a problem hiding this comment.
added a small disclaimer, I would like to add more benchmark in the future so I'm not very specific.
| echo 'BENCHMARK_SECTION<<EOF' | ||
| echo "<details>" | ||
| echo "<summary>📊 Benchmark results</summary>" | ||
| echo "" # empty line is required to make the table work |
There was a problem hiding this comment.
do we still need it now that we have a comment?
There was a problem hiding this comment.
this specific line 492 which add an empty line
There was a problem hiding this comment.
yes otherwise it looks like this
millotp
force-pushed
the
chore/report-benchmark
branch
from
564e1c8 to
64f7b3d
Compare
🧭 What and Why
Report benchmark results in the generation comment directly