Skip to content

chore(scripts): improve generation commit message #3419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

shortcuts
Copy link
Member

@shortcuts shortcuts commented Jul 25, 2024

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DI-2680

Changes included:

While commit messages have little context here https://github.com/algolia/api-clients-automation/commits/main/, it's super ugly on client repositories https://github.com/algolia/algoliasearch-client-go/commits/next/

In this PR, we try to provide the exact same message as the original commit, plus a link to the repo's PR

@shortcuts shortcuts requested a review from a team as a code owner July 25, 2024 14:38
@shortcuts shortcuts requested review from morganleroi and millotp July 25, 2024 14:38
@shortcuts shortcuts self-assigned this Jul 25, 2024
@algolia-bot
Copy link
Collaborator

algolia-bot commented Jul 25, 2024

No code generated

If you believe code should've been generated, please, report the issue.

📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Rate
javascript 1329
php 1287
csharp 1112
java 917
ruby 910
swift 756
python 756
kotlin 484
go 453

Copy link

Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets try it !

@shortcuts
Copy link
Member Author

lets try it !

lets hope it works D:

@shortcuts shortcuts merged commit 90762d1 into main Jul 25, 2024
21 checks passed
@shortcuts shortcuts deleted the chore/generation-commit-message branch July 25, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants