Skip to content

chore(scripts): replace tsc by esbuild #3425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 26, 2024
Merged

chore(scripts): replace tsc by esbuild #3425

merged 8 commits into from
Jul 26, 2024

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Jul 26, 2024

🧭 What and Why

Replace tsc and ncc by esbuild which is 100 times faster, so fast that we can directly put it in the apic command and not worry about forgetting to build the scripts.

I also discovered node --enable-source-maps which is a game changer, and gives us true typescript stack trace instead of the ugly js

@millotp millotp self-assigned this Jul 26, 2024
@millotp millotp requested a review from a team as a code owner July 26, 2024 12:03
@millotp millotp requested review from morganleroi and Fluf22 July 26, 2024 12:03
@algolia-bot
Copy link
Collaborator

algolia-bot commented Jul 26, 2024

No code generated

If you believe code should've been generated, please, report the issue.

📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Rate
javascript 1356
php 1342
csharp 1048
java 950
ruby 926
python 717
swift 703
kotlin 471
go 466

Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is hugeee

Copy link

github-actions bot commented Jul 26, 2024

shortcuts
shortcuts previously approved these changes Jul 26, 2024
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huge improvements!!

@millotp millotp merged commit 793c138 into main Jul 26, 2024
21 checks passed
@millotp millotp deleted the chore/esbuild branch July 26, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants