Skip to content

fix(scripts): sla update date #3492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 8, 2024
Merged

fix(scripts): sla update date #3492

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions scripts/release/__tests__/sla.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,19 @@ describe('generateLanguageSLA', () => {
const end = new Date(start);
end.setFullYear(start.getFullYear() + 2);

it('same version as active version', () => {
generateLanguageSLA([
"1.2.4 Thu Dec 28 15:48:25 2023 +0000",
], 'dart', {next: "1.2.4", current: "1.2.4", releaseType: "minor"})

expect(fullReleaseConfig.sla.dart).toEqual({
"1.2.4": {
"releaseDate": "2023-12-28",
"supportStatus":"active",
}
})
});

it('new major: sets the new release as active, sets the last tag as maintenance', () => {
generateLanguageSLA([
"1.2.4 Thu Dec 28 15:48:25 2023 +0000",
Expand Down
2 changes: 1 addition & 1 deletion scripts/release/sla.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ export function generateLanguageSLA(tags: string[], lang: Language, version: Ver
}

// if there's no release planned, or if the release is a pre-release, then the latest tagged version is the active one
if (!version?.next || isPreRelease(version?.next)) {
if (!version?.next || isPreRelease(version?.next) || version?.next === prevTagVersion) {
fullReleaseConfig.sla[lang][prevTagVersion].supportStatus = 'active';

return;
Expand Down
Loading