Skip to content

chore: prevent cancel on release commits #3560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 20, 2024
Merged

Conversation

shortcuts
Copy link
Member

🧭 What and Why

🎟 JIRA Ticket: -

Changes included:

we can prevent cancelling CI runs of release commit as recommended here https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/control-the-concurrency-of-workflows-and-jobs#example-only-cancel-in-progress-jobs-on-specific-branches

@shortcuts shortcuts self-assigned this Aug 20, 2024
@shortcuts shortcuts requested a review from a team as a code owner August 20, 2024 12:57
@algolia-bot
Copy link
Collaborator

algolia-bot commented Aug 20, 2024

No code generated

If you believe code should've been generated, please, report the issue.

📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Rate
javascript 1373
php 1369
csharp 1090
java 896
ruby 868
swift 740
python 739
go 464
kotlin 430

@@ -11,7 +11,7 @@ on:

concurrency:
group: ${{ github.ref }}
cancel-in-progress: true
cancel-in-progress: ${{ !contains(github.event.head_commit.message, 'prepare release')}}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@Fluf22 Fluf22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

Copy link

github-actions bot commented Aug 20, 2024

@shortcuts shortcuts enabled auto-merge (squash) August 20, 2024 13:11
@shortcuts shortcuts disabled auto-merge August 20, 2024 13:11
@shortcuts shortcuts enabled auto-merge (squash) August 20, 2024 13:18
@shortcuts shortcuts merged commit f73cb83 into main Aug 20, 2024
21 checks passed
@shortcuts shortcuts deleted the chore/dont-cancel-releases branch August 20, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants