feat(php): waitForTasks param for various SearchClient methods #3565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added $waitForTasks param for various methods in SearchClient
aykutersoy
changed the title
…ods-for-SearchClient
millotp
reviewed
Aug 20, 2024
templates/php/api.mustache
Outdated
| */ | ||
| public function replaceAllObjects($indexName, $objects, $batchSize = 1000, $requestOptions = []) | ||
| public function replaceAllObjects($indexName, $objects, $batchSize = 1000, $requestOptions = [], $waitForTasks = true) |
There was a problem hiding this comment.
The waitForTask is required for this helper to work properly, without this it might end up in a infinite loop so I would recommend to leave it as is.
There was a problem hiding this comment.
Reverted! Thanks for your comment and reviewing this 🙌
…rchClient' of github.com:aykutersoy/api-clients-automation into feat/php-waitForTasks-param-for-various-methods-for-SearchClient
|
@millotp Amazing! Thank you very much for speedy review and approval 🙌 |
|
you're welcome ! I will merge both of your PR once the CI on main is finished |
…ods-for-SearchClient
algolia-bot
added a commit
that referenced
this pull request
Aug 20, 2024
… (generated) [skip ci] Co-authored-by: Aykut Ersoy <[email protected]>
algolia-bot
added a commit
to algolia/algoliasearch-client-php
that referenced
this pull request
Aug 20, 2024
…ated) algolia/api-clients-automation#3565 Co-authored-by: algolia-bot <[email protected]> Co-authored-by: Aykut Ersoy <[email protected]>
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
waitForTask()for some SearchClient method calls (ie.deleteObjects) I thought sincechuckedBatchis already doing this, why not add a parameter to hand over waitForTasks to Algolia client instead of us doing it manually.🎟 JIRA Ticket: -
Changes included:
$waitForTasksparamchunkedBatch()🧪 Test