Skip to content

fix(scripts): dont fail on empty benchamrk #3573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 22, 2024
Merged

fix(scripts): dont fail on empty benchamrk #3573

merged 1 commit into from
Aug 22, 2024

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Aug 22, 2024

🧭 What and Why

Ignore the benckmark report when the matrix is empty.
Also fix the common templates.

@millotp millotp requested a review from a team as a code owner August 22, 2024 10:11
@millotp millotp requested review from morganleroi and Fluf22 August 22, 2024 10:11
@millotp millotp self-assigned this Aug 22, 2024
@algolia-bot
Copy link
Collaborator

algolia-bot commented Aug 22, 2024

No code generated

If you believe code should've been generated, please, report the issue.

📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
javascript 1369
php 1360
csharp 1084
ruby 896
java 887
swift 749
python 730
go 533
kotlin 472

Copy link
Contributor

@Fluf22 Fluf22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Joli

@millotp millotp enabled auto-merge (squash) August 22, 2024 10:21
Copy link

@millotp millotp merged commit 8c1d83e into main Aug 22, 2024
21 checks passed
@millotp millotp deleted the fix/empty-bench branch August 22, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants