Skip to content

fix(swift): accept any type during json encoding #3576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

Fluf22
Copy link
Contributor

@Fluf22 Fluf22 commented Aug 22, 2024

🧭 What and Why

🎟 JIRA Ticket: closes GH-ISSUE #867 & DI-2789

Changes included:

  • Accept any types during JSON encoding

@Fluf22 Fluf22 self-assigned this Aug 22, 2024
@Fluf22 Fluf22 requested a review from a team as a code owner August 22, 2024 15:26
@Fluf22 Fluf22 requested review from millotp and shortcuts August 22, 2024 15:26
@algolia-bot
Copy link
Collaborator

algolia-bot commented Aug 22, 2024

No code generated

If you believe code should've been generated, please, report the issue.

📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
swift 738

Copy link

github-actions bot commented Aug 22, 2024

Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gg

@Fluf22 Fluf22 force-pushed the fix/swift-json-encoding branch from f2f283b to 647c8ff Compare August 22, 2024 15:44
@Fluf22 Fluf22 enabled auto-merge (squash) August 22, 2024 15:45
@Fluf22 Fluf22 merged commit 7d08d1e into main Aug 22, 2024
12 checks passed
@Fluf22 Fluf22 deleted the fix/swift-json-encoding branch August 22, 2024 15:58
algolia-bot added a commit to algolia/algoliasearch-client-swift that referenced this pull request Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fatal error: could not decode from data holder
3 participants