-
Notifications
You must be signed in to change notification settings - Fork 21
feat(python): add sync client #3609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✔️ Code generated!
📊 Benchmark resultsBenchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
|
b6afe81
to
c64a3a4
Compare
…ated) [skip ci] Co-authored-by: Clément Vannicatte <[email protected]>
c64a3a4
to
2ff422b
Compare
millotp
reviewed
Sep 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good !
generators/src/main/java/com/algolia/codegen/AlgoliaPythonGenerator.java
Show resolved
Hide resolved
generators/src/main/java/com/algolia/codegen/cts/AlgoliaCTSGenerator.java
Outdated
Show resolved
Hide resolved
millotp
approved these changes
Sep 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perfect !
algolia-bot
added a commit
that referenced
this pull request
Sep 9, 2024
Co-authored-by: Clément Vannicatte <[email protected]>
algolia-bot
added a commit
to algolia/algoliasearch-client-python
that referenced
this pull request
Sep 9, 2024
algolia/api-clients-automation#3609 Co-authored-by: algolia-bot <[email protected]> Co-authored-by: Clément Vannicatte <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://algolia.atlassian.net/browse/DI-2751 https://algolia.atlassian.net/browse/CR-6696
closes algolia/algoliasearch-client-python#568
this pr adds a sync client class to the algoliasearch package, it is as tested as the async one by simply having a copy of each cases in a list, where one has
isSync
to true in order to comment out async/await statementsthe only real client addition lies in the
http
package, we now have a base transporter in with some parsing utils in order to create a sync and async transporter for each client class