Skip to content

feat(python): add sync client #3609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Sep 9, 2024
Merged

feat(python): add sync client #3609

merged 25 commits into from
Sep 9, 2024

Conversation

shortcuts
Copy link
Member

@shortcuts shortcuts commented Aug 28, 2024

https://algolia.atlassian.net/browse/DI-2751 https://algolia.atlassian.net/browse/CR-6696
closes algolia/algoliasearch-client-python#568

this pr adds a sync client class to the algoliasearch package, it is as tested as the async one by simply having a copy of each cases in a list, where one has isSync to true in order to comment out async/await statements

the only real client addition lies in the http package, we now have a base transporter in with some parsing utils in order to create a sync and async transporter for each client class

@shortcuts shortcuts requested a review from a team as a code owner August 28, 2024 20:37
@algolia-bot
Copy link
Collaborator

algolia-bot commented Aug 28, 2024

✔️ Code generated!

Name Link
🪓 Triggered by 59676e2c83f0bb1a810dec90e36015b00ab90db5
🍃 Generated commit 0cb062c70cea885e27026783916b0017cc82026d
🌲 Generated branch generated/feat/python-sync
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
javascript 1589
php 1515
python 1054
csharp 1049
java 970
ruby 882
swift 786
go 568

@shortcuts shortcuts marked this pull request as draft August 28, 2024 20:38
Copy link

github-actions bot commented Aug 28, 2024

@shortcuts shortcuts changed the base branch from main to chore/python-multi-version-ci August 29, 2024 14:08
Base automatically changed from chore/python-multi-version-ci to main August 29, 2024 15:39
@shortcuts shortcuts marked this pull request as ready for review September 6, 2024 18:33
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good !

@shortcuts shortcuts enabled auto-merge (squash) September 9, 2024 09:46
@shortcuts shortcuts disabled auto-merge September 9, 2024 09:46
@shortcuts shortcuts enabled auto-merge (squash) September 9, 2024 09:47
@shortcuts shortcuts requested a review from millotp September 9, 2024 10:00
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect !

@shortcuts shortcuts merged commit b6e273f into main Sep 9, 2024
28 checks passed
@shortcuts shortcuts deleted the feat/python-sync branch September 9, 2024 10:04
algolia-bot added a commit that referenced this pull request Sep 9, 2024
algolia-bot added a commit to algolia/algoliasearch-client-python that referenced this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add synchronous support to v4+
3 participants