Skip to content

fix(csharp): add helpers to ISearchClient #3657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 6, 2024
Merged

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Sep 6, 2024

🧭 What and Why

🎟 JIRA Ticket: DI-2888. closes algolia/algoliasearch-client-csharp#864

Added all the helpers to the search interface, and cleaned up the documentation by using inheritdoc.

Also fix all the warnings, such as missing doc or vulnerable lib:
Screenshot 2024-09-06 at 09 03 13

@millotp millotp self-assigned this Sep 6, 2024
@millotp millotp requested a review from a team as a code owner September 6, 2024 07:04
@millotp millotp requested review from Fluf22 and shortcuts September 6, 2024 07:04
@algolia-bot
Copy link
Collaborator

algolia-bot commented Sep 6, 2024

✔️ Code generated!

Name Link
🪓 Triggered by 391299302c499b0cecb0a1bc8599d8e9b6431296
🍃 Generated commit f56a3079e61a91c24502afc4304ff3f7c9021164
🌲 Generated branch generated/fix/csharp-interface
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
csharp 1165

Copy link

github-actions bot commented Sep 6, 2024

Copy link
Contributor

@morganleroi morganleroi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing it !

@millotp millotp merged commit 8c717c1 into main Sep 6, 2024
12 checks passed
@millotp millotp deleted the fix/csharp-interface branch September 6, 2024 07:38
algolia-bot added a commit that referenced this pull request Sep 6, 2024
algolia-bot added a commit to algolia/algoliasearch-client-csharp that referenced this pull request Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: V7 ISearchClient does not expose PartialUpdateObjectsAsync nor PartialUpdateObjects
3 participants