Skip to content

fix(javascript): assert helpers and fix setClientApiKey helper #3663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

shortcuts
Copy link
Member

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DI-2894

Changes included:

asserts the inherited helpers from search client and reflect different auth modes for the setClientApiKey helper

@shortcuts shortcuts self-assigned this Sep 6, 2024
@shortcuts shortcuts requested a review from a team as a code owner September 6, 2024 18:54
@algolia-bot
Copy link
Collaborator

algolia-bot commented Sep 6, 2024

✔️ Code generated!

Name Link
🪓 Triggered by ebfc24026f4f372f14b4be5b892c188c6973064d
🍃 Generated commit 87675e299a56a6e99e69401d2a9998cfe8199527
🌲 Generated branch generated/fix/javascript-algoliasearch-helpers
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
javascript 1661

Copy link

github-actions bot commented Sep 6, 2024

@shortcuts shortcuts merged commit 50bd073 into main Sep 9, 2024
12 checks passed
@shortcuts shortcuts deleted the fix/javascript-algoliasearch-helpers branch September 9, 2024 06:39
algolia-bot added a commit that referenced this pull request Sep 9, 2024
… (generated) [skip ci]

Co-authored-by: Clément Vannicatte <[email protected]>
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants