fix(python): update deserialization templates and typing issues #3780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✔️ Code generated!
📊 Benchmark resultsBenchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
|
shortcuts
changed the title
millotp
approved these changes
Sep 24, 2024
| @@ -0,0 +1,6 @@ | |||
| argcomplete==3.5.0 | |||
There was a problem hiding this comment.
is the CI deleting this file everytime ? I see it everywhere
There was a problem hiding this comment.
I think it doesn't push it on the CI but I can't understand why ahaha
algolia-bot
added a commit
that referenced
this pull request
Sep 24, 2024
… (generated) [skip ci] Co-authored-by: Clément Vannicatte <[email protected]>
algolia-bot
added a commit
to algolia/algoliasearch-client-python
that referenced
this pull request
Sep 24, 2024
…rated) algolia/api-clients-automation#3780 Co-authored-by: algolia-bot <[email protected]> Co-authored-by: Clément Vannicatte <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DI-2787 https://algolia.atlassian.net/browse/DI-2915
Changes included:
supersede #3758
this pr updates the python template in order to better leverage pydantic and improve usage in general:
extrafields for native additional properties supportto_dictunwrap in tests rather than the model-level one, this allows us to have a more concrete usage, as it's unlikely that users will iterate over the fields to parse them