Skip to content

fix(clients): use the dsn with the read transporter #3781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Sep 19, 2024

🧭 What and Why

The java search client is not using the read transporter at all.

@millotp millotp self-assigned this Sep 19, 2024
@millotp millotp requested a review from a team as a code owner September 19, 2024 16:06
@algolia-bot
Copy link
Collaborator

algolia-bot commented Sep 19, 2024

✔️ Code generated!

Name Link
🪓 Triggered by 45fb6171ec5266ef0b962250e789fc11cbdd3ac0
🍃 Generated commit 45cf7ca00794fc6c86bb2fe1122f78ae4315ea19
🌲 Generated branch generated/fix/java-host
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
javascript 1587
php 1447
python 1019
csharp 1002
java 921
ruby 885
swift 751
go 555

@millotp millotp changed the title fix(java): use the dsn with the read transporter fix(clients): use the dsn with the read transporter Sep 19, 2024
Copy link
Contributor

@Fluf22 Fluf22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should work indeed

@millotp millotp merged commit 4f64d5f into main Sep 19, 2024
29 checks passed
@millotp millotp deleted the fix/java-host branch September 19, 2024 17:19
algolia-bot added a commit that referenced this pull request Sep 19, 2024
algolia-bot added a commit to algolia/algoliasearch-client-java that referenced this pull request Sep 19, 2024
algolia-bot added a commit to algolia/algoliasearch-client-scala that referenced this pull request Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants