feat(templates): add request_options to python helpers consistently #3868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✔️ Code generated!
📊 Benchmark resultsBenchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
|
kai687
changed the title
Fluf22
approved these changes
Oct 2, 2024
algolia-bot
added a commit
that referenced
this pull request
Oct 2, 2024
…3868) (generated) [skip ci] Co-authored-by: Kai Welke <[email protected]>
algolia-bot
added a commit
to algolia/algoliasearch-client-python
that referenced
this pull request
Oct 2, 2024
…generated) algolia/api-clients-automation#3868 Co-authored-by: algolia-bot <[email protected]> Co-authored-by: Kai Welke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
Make the Python helpers more consistent by supporting
request_optionsfor all helpersthat are based on
chunked_batch.Changes included:
Add
request_optionsto the following helpers:save_objectsdelete_objectspartial_update_objectsThe rest of them already work with
request_options.Also provide
dictas accepted type for API key restrictions ingenerate_secured_api_key, since the function already handles that case.