chore(javascript): use oxlint #3895
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✔️ Code generated!
📊 Benchmark resultsBenchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
|
shortcuts
force-pushed
the
chore/javascript-oxlint
branch
2 times, most recently
from
c68ea9c to
e5d226e
Compare
shortcuts
force-pushed
the
chore/javascript-oxlint
branch
from
e5d226e to
8444131
Compare
|
ahah I tried it too last week, turns out its not a formatter and doesn't remove white spaces or any stylistic fixes (https://oxc.rs/docs/guide/usage/linter#language-support), so not ideal for generated code |
millotp
reviewed
Oct 7, 2024
shortcuts
force-pushed
the
chore/javascript-oxlint
branch
from
1841197 to
262ad89
Compare
millotp
approved these changes
Oct 7, 2024
algolia-bot
added a commit
that referenced
this pull request
Oct 8, 2024
Co-authored-by: Clément Vannicatte <[email protected]>
algolia-bot
added a commit
to algolia/algoliasearch-client-javascript
that referenced
this pull request
Oct 8, 2024
algolia/api-clients-automation#3895 Co-authored-by: algolia-bot <[email protected]> Co-authored-by: Clément Vannicatte <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DI-3035
Changes included:
trying out oxlint instead of oslint, performance improvements on the ci are considerable, the output changes but nothing crazy, mostly syntactic sugar
let's discuss it