Skip to content

fix(ruby): prefix models by the module #3927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 9, 2024
Merged

fix(ruby): prefix models by the module #3927

merged 2 commits into from
Oct 9, 2024

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Oct 8, 2024

🧭 What and Why

The cts, guides, and snippets, should use this syntax to work out of the box, without importing anything.

@millotp millotp self-assigned this Oct 8, 2024
@millotp millotp requested a review from a team as a code owner October 8, 2024 13:24
@millotp millotp requested review from Fluf22 and shortcuts October 8, 2024 13:24
@algolia-bot
Copy link
Collaborator

algolia-bot commented Oct 8, 2024

✔️ Code generated!

Name Link
🪓 Triggered by 51d5b82095c50adab7a7849fb414e64fab263ac3
🍃 Generated commit c8d6df8af71bd3c998957e887e8ac4bcf4af9088
🌲 Generated branch generated/fix/ruby-prefix
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
ruby 954

Copy link
Contributor

@Fluf22 Fluf22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@millotp millotp enabled auto-merge (squash) October 9, 2024 10:33
@millotp millotp merged commit 54e1b5b into main Oct 9, 2024
12 checks passed
@millotp millotp deleted the fix/ruby-prefix branch October 9, 2024 10:40
algolia-bot added a commit that referenced this pull request Oct 9, 2024
algolia-bot added a commit to algolia/algoliasearch-client-ruby that referenced this pull request Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants