Skip to content

chore: persist snippets on main #3929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Oct 9, 2024
Merged

chore: persist snippets on main #3929

merged 9 commits into from
Oct 9, 2024

Conversation

shortcuts
Copy link
Member

@shortcuts shortcuts commented Oct 8, 2024

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DI-3034

Changes included:

see generated code of ef141ea, since we don't persist snippets on main, the json snippet file is created based on what runs in the latest ci, meaning that if only 1 client runs, every other snippets are deleted

@shortcuts shortcuts self-assigned this Oct 8, 2024
@algolia-bot
Copy link
Collaborator

algolia-bot commented Oct 8, 2024

✔️ Code generated!

Name Link
🪓 Triggered by 4f02935e34eae33b4cdd48cf57d84f50f4751c23
🍃 Generated commit 13d8d849c7c73bb07de0b727eeb18a0df7030a29
🌲 Generated branch generated/chore/persist-snippets-main
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
javascript 1658
go 1654
php 1443
csharp 1304
java 1123
python 1052
ruby 880
swift 742

@shortcuts shortcuts force-pushed the chore/persist-snippets-main branch 2 times, most recently from 6a90ad3 to 7f5aa04 Compare October 8, 2024 15:10
@shortcuts shortcuts force-pushed the chore/persist-snippets-main branch from 7f5aa04 to d96cd6d Compare October 8, 2024 15:12
@shortcuts shortcuts marked this pull request as ready for review October 8, 2024 15:27
@shortcuts shortcuts requested a review from a team as a code owner October 8, 2024 15:27
Copy link

github-actions bot commented Oct 9, 2024

Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfecto

@millotp millotp merged commit 45e0b8b into main Oct 9, 2024
28 checks passed
@millotp millotp deleted the chore/persist-snippets-main branch October 9, 2024 09:17
algolia-bot added a commit that referenced this pull request Oct 9, 2024
Co-authored-by: Clément Vannicatte <[email protected]>
Co-authored-by: Pierre Millot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants