Skip to content

fix(specs): multiple clients fixes #3971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Oct 16, 2024
Merged

fix(specs): multiple clients fixes #3971

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
1ff693d
fix(specs): multiple clients fixes
shortcuts Oct 15, 2024
f55e50f
chore: more fixes
shortcuts Oct 15, 2024
183f5a8
chore: readme
shortcuts Oct 15, 2024
9c918df
chore: applied rules description
shortcuts Oct 15, 2024
d66b821
chore: not yet
shortcuts Oct 15, 2024
c05e04f
fix: requests is required
shortcuts Oct 15, 2024
069cf7b
fix: getObjects resp is nullable
shortcuts Oct 15, 2024
164da5d
Merge branch 'main' into fix/specs-vinnie-review
shortcuts Oct 15, 2024
5bc8eaa
chore: struggling with kotlin? `man mouaad` in the cli
shortcuts Oct 15, 2024
348c994
Merge branch 'main' into fix/specs-vinnie-review
shortcuts Oct 15, 2024
8f325e2
chore: a fix that isn't a real fix
shortcuts Oct 16, 2024
c8f05a4
Merge branch 'main' into fix/specs-vinnie-review
shortcuts Oct 16, 2024
548d23e
chore: alors peut-etre que
shortcuts Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions specs/abtesting/common/schemas/ABTest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,8 +124,6 @@ ABTestConfiguration:
$ref: '#/EmptySearch'
minimumDetectableEffect:
$ref: '#/MinimumDetectableEffect'
required:
- outliers

Outliers:
type: object
Expand Down
1 change: 0 additions & 1 deletion specs/abtesting/common/schemas/Variant.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,6 @@ variant:
- searchCount
- noResultCount
- index
- description
- conversionCount
- clickCount
- addToCartCount
Expand Down
6 changes: 6 additions & 0 deletions specs/common/schemas/SearchResponse.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,12 @@ baseSearchResponse:
type: boolean
title: typo
description: Whether the typo search was exhaustive (`true`) or approximate (`false`). An approximation is done when the typo search query part takes more than 10% of the query budget (ie. 5ms by default) to be processed (this can happen when a lot of typo alternatives exist for the query). This field will not be included when typo-tolerance is entirely disabled.
appliedRules:
description: Rules applied to the query.
title: appliedRules
type: array
items:
type: object
exhaustiveFacetsCount:
type: boolean
description: See the `facetsCount` field of the `exhaustive` object in the response.
Expand Down
2 changes: 1 addition & 1 deletion specs/search/paths/keys/common/schemas.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ baseGetApiKeyResponse:
createdAt:
$ref: '../../../../common/responses/common.yml#/createdAtTimestamp'
required:
- key
- value
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird that redocly doesn't warn about that, I'm sure we have the same somewhere else

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was shocked too idk how it went through?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually there are some warnings like Component: "attributeToUpdate" is never used.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah in the warnings we silence? I'll check that

- createdAt

addApiKeyResponse:
Expand Down
2 changes: 0 additions & 2 deletions specs/search/paths/objects/getObjects.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,6 @@ post:
type: object
description: Retrieved record.
x-is-generic: true
required:
- results
'400':
$ref: '../../../common/responses/BadRequest.yml'
'402':
Expand Down
1 change: 0 additions & 1 deletion specs/search/paths/synonyms/common/schemas.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ synonymHit:
example: 'synonymID'
type:
$ref: './parameters.yml#/SynonymType'

synonyms:
type: array
items:
Expand Down
Loading