Skip to content

fix(ruby): provide default ttl #4027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 23, 2024
Merged

fix(ruby): provide default ttl #4027

merged 2 commits into from
Oct 23, 2024

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Oct 23, 2024

🧭 What and Why

closes algolia/algoliasearch-client-ruby#504

The client is referencing an file that doesn't exists anymore

@millotp millotp requested a review from a team as a code owner October 23, 2024 15:01
@millotp millotp requested review from Fluf22 and shortcuts October 23, 2024 15:01
@algolia-bot
Copy link
Collaborator

algolia-bot commented Oct 23, 2024

✔️ Code generated!

Name Link
🪓 Triggered by 795c1547ac147f335ac84af776e922f50b77dbef
🍃 Generated commit 89f64bed5158494d188975d994de481e2c789531
🌲 Generated branch generated/fix/ruby-ttl
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
javascript 1707
go 1648
php 1504
csharp 1284
java 1143
python 998
ruby 896
swift 747

Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wonderful

Copy link
Contributor

@Fluf22 Fluf22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@millotp millotp merged commit 46ba4b5 into main Oct 23, 2024
28 checks passed
@millotp millotp deleted the fix/ruby-ttl branch October 23, 2024 15:29
algolia-bot added a commit that referenced this pull request Oct 23, 2024
algolia-bot added a commit to algolia/algoliasearch-client-ruby that referenced this pull request Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants