Skip to content

chore(swift): fix configuration protection level #4028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

Fluf22
Copy link
Contributor

@Fluf22 Fluf22 commented Oct 24, 2024

🧭 What and Why

🎟 JIRA Ticket: DI-3103 & fixes algolia/algoliasearch-client-swift#872

Changes included:

  • make the client configuration init public

@Fluf22 Fluf22 requested a review from a team as a code owner October 24, 2024 13:28
@Fluf22 Fluf22 requested review from morganleroi and millotp October 24, 2024 13:28
@Fluf22 Fluf22 self-assigned this Oct 24, 2024
@algolia-bot
Copy link
Collaborator

algolia-bot commented Oct 24, 2024

✔️ Code generated!

Name Link
🪓 Triggered by 4b4749c19c3e8735e97891f7e92d763e2b50d7cc
🍃 Generated commit 2887725bf8418c4ff2e85339245b25e249ae5a14
🌲 Generated branch generated/fix/swift-config-public
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
swift 755

@Fluf22 Fluf22 requested a review from shortcuts October 24, 2024 14:04
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops

@Fluf22 Fluf22 merged commit c7abcf9 into main Oct 24, 2024
17 checks passed
@Fluf22 Fluf22 deleted the fix/swift-config-public branch October 24, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: OpenAPI generated SearchClientConfiguration swift code missing public init making the API unusable
3 participants