-
Notifications
You must be signed in to change notification settings - Fork 21
docs: update contribution guides [skip-bc] #4051
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
No code generatedIf you believe code should've been generated, please, report the issue. 📊 Benchmark resultsBenchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is so nice
Make sure to have Docker installed so you don't have to install the tooling for every API clients. [Installation guide](https://docs.docker.com/desktop/mac/install/) | ||
Make sure to have: | ||
- [Docker installed so you don't have to install the tooling for every API clients](https://docs.docker.com/desktop/mac/install/) | ||
- [jq because it's nice](https://jqlang.github.io/jq/download/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
|
||
::: | ||
This step is optional, using `yarn cli ...` should work perfectly as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup but a bit intrusive so... that's fine I guess
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apic
is mostly about the auto-completion rather than the speed, I think this is the main advantage
website/docs/CLI/build-commands.md
Outdated
### Build many snippets for specific language | ||
|
||
```bash | ||
apic build snippets php insights recommend search |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
php build is a noop still 😢
phpstan
is too hard
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can put python instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gg
🧭 What and Why
🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DI-3114
Changes included:
some feedbacks reported by @e-krebs for the contribution guides, also some alignment on the names scripts->docs