Skip to content

chore(eslint): add linter to forbid bigInt [skip-bc] #4094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Nov 12, 2024

🧭 What and Why

I saw this type in one of the external contribution, we should never allow BitInteger or BigDecimal types

@millotp millotp self-assigned this Nov 12, 2024
@millotp millotp requested a review from a team as a code owner November 12, 2024 09:38
@algolia-bot
Copy link
Collaborator

algolia-bot commented Nov 12, 2024

✔️ Code generated!

Name Link
🪓 Triggered by a0adb6b1cc123c08eeff92bf9aa1250f17e6ca8a
🍃 Generated commit 0e02341e2a9dd27dca89cfcb74d737ab2b9f3d71
🌲 Generated branch generated/chore/noBigInt
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
go 1655
javascript 1618
php 1517
csharp 1301
java 1128
python 1026
ruby 890
swift 759

layout: false,
},
messages: {
noBigInt: 'type bigInt is forbidden',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should it recommend the solution? not as an automated fix but at least a clear alternative

@millotp millotp changed the title chore(eslint): add linter to forbid bigInt chore(eslint): add linter to forbid bigInt [skip-bc] Nov 12, 2024
@millotp millotp requested a review from shortcuts November 12, 2024 09:58
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

incredible

@millotp millotp merged commit 28dacd6 into main Nov 12, 2024
28 checks passed
@millotp millotp deleted the chore/noBigInt branch November 12, 2024 10:23
algolia-bot added a commit that referenced this pull request Nov 12, 2024
millotp added a commit that referenced this pull request Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants