Skip to content

fix(clients): use correct user agent #4103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 14, 2024
Merged

fix(clients): use correct user agent #4103

merged 4 commits into from
Nov 14, 2024

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Nov 14, 2024

🧭 What and Why

The User-Agent in the header is case insensitive, but the query parameter x-algolia-agent is case sensitive and should always be in lowercase.
Also fix swift.

@millotp millotp self-assigned this Nov 14, 2024
@millotp millotp requested a review from a team as a code owner November 14, 2024 10:56
@algolia-bot
Copy link
Collaborator

algolia-bot commented Nov 14, 2024

✔️ Code generated!

Name Link
🪓 Triggered by 4835fe2d394e69e7a5ad11abd04c53288abd3afe
🍃 Generated commit 6ac0a8ac3b0b09ef1462e2b7970e2e08928b957f
🌲 Generated branch generated/fix/user-agent
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
swift 759

Copy link

github-actions bot commented Nov 14, 2024

Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great catch

@millotp millotp enabled auto-merge (squash) November 14, 2024 12:42
@millotp millotp merged commit 0985a1c into main Nov 14, 2024
13 checks passed
@millotp millotp deleted the fix/user-agent branch November 14, 2024 13:09
algolia-bot added a commit that referenced this pull request Nov 14, 2024
algolia-bot added a commit to algolia/algoliasearch-client-dart that referenced this pull request Nov 14, 2024
algolia-bot added a commit to algolia/algoliasearch-client-swift that referenced this pull request Nov 14, 2024
millotp added a commit that referenced this pull request Nov 18, 2024
millotp added a commit that referenced this pull request Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants