fix(scripts): dart and js releases [skip-bc] #4104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No code generatedIf you believe code should've been generated, please, report the issue. 📊 Benchmark resultsBenchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
|
shortcuts
commented
Nov 14, 2024
scripts/release/dart.ts
Outdated
There was a problem hiding this comment.
nothing changed here, just moved the code
shortcuts
commented
Nov 14, 2024
Comment on lines
+61
to
64
| if (lang === 'javascript' && releaseType) { | ||
| setVerbose(CI); | ||
| await run(`yarn install && yarn release:bump ${releaseType}`, { | ||
| cwd: getLanguageFolder(lang), | ||
| }); | ||
| await updateJavaScriptPackages(releaseType); | ||
| } |
There was a problem hiding this comment.
except the code move, this was the only change
shortcuts
changed the title
algolia-bot
added a commit
to algolia/algoliasearch-client-javascript
that referenced
this pull request
Nov 14, 2024
algolia/api-clients-automation#4104 Co-authored-by: Clément Vannicatte <[email protected]>
millotp
pushed a commit
that referenced
this pull request
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DI-3212
Changes included:
undefinedversions of dartlernafor version bumping as it doesn't support mixed package stage (stable and pre-release) bumps nor filtering on package bumps (e.g. bumping stable then bumping pre-releases with different release type)lernathen useyarndirectly to bump the version based on thereleaseTypealso move dart and js custom logic to their own file because it became a mess in that release script file
Test:
run
yarn cli release -b -dand see dart properly bumped, javascript as well