Skip to content

fix(javascript): set latest version on prereleases #4138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

shortcuts
Copy link
Member

🧭 What and Why

🎟 JIRA Ticket: -

Changes included:

the published alpha version isn't set as the latest available, meaning that npm shows the .1 everytime (cf screenshot)

we now set the latest tag explicitly, which seems to be enough https://www.npmjs.com/package/@algolia/client-composition?activeTab=versions

image

@shortcuts shortcuts self-assigned this Nov 20, 2024
@shortcuts shortcuts requested a review from a team as a code owner November 20, 2024 11:37
@algolia-bot
Copy link
Collaborator

algolia-bot commented Nov 20, 2024

No code generated

If you believe code should've been generated, please, report the issue.

📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
javascript 1606

Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't need to do it for the normal packages ?

@shortcuts
Copy link
Member Author

we don't need to do it for the normal packages ?

no it's the default value of the tag argument

@shortcuts shortcuts merged commit 2e894c9 into main Nov 20, 2024
12 checks passed
@shortcuts shortcuts deleted the fix/javascript-publish-alpha-latest branch November 20, 2024 13:18
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants