fix(javascript): allow async param on createIterablePromise #4144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✔️ Code generated!
📊 Benchmark resultsBenchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
|
shortcuts
reviewed
Nov 22, 2024
actually just a test in client-common would be good? |
shortcuts
reviewed
Nov 22, 2024
Comment on lines
+5
to
+6
| "outDir": "dist", | ||
| "skipLibCheck": true |
There was a problem hiding this comment.
Suggested change
| "outDir": "dist", | |
| "skipLibCheck": true | |
| "outDir": "dist" |
does it still work without it?
There was a problem hiding this comment.
nope, still complains about rollup
algolia-bot
added a commit
that referenced
this pull request
Nov 22, 2024
…generated) [skip ci] Co-authored-by: Pierre Millot <[email protected]>
algolia-bot
added a commit
to algolia/algoliasearch-client-javascript
that referenced
this pull request
Nov 22, 2024
algolia/api-clients-automation#4144 Co-authored-by: algolia-bot <[email protected]> Co-authored-by: Pierre Millot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
Allow all params of
createIterablePromiseto returnPromiseLikeand call them with await, if people want to useawaitinside their fonctions.This is not a breaking change and stays compatible with before.