Skip to content

fix(specs): saveRule response type [skip-bc] #4170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 26, 2024
Merged

Conversation

shortcuts
Copy link
Member

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DI-3246

Changes included:

seems like a wrong type leftover from 2 years ago but no objectID fields are returned from the response, it actually returns {"updatedAt":"2024-11-26T16:07:56.523Z","taskID":588516396000}

@shortcuts shortcuts self-assigned this Nov 26, 2024
@shortcuts shortcuts requested a review from a team as a code owner November 26, 2024 16:09
@shortcuts shortcuts changed the title fix(specs): saveRule response type fix(specs): saveRule response type [skip-bc] Nov 26, 2024
@algolia-bot
Copy link
Collaborator

algolia-bot commented Nov 26, 2024

✔️ Code generated!

Name Link
🪓 Triggered by 31e07080bf0d283c792cf2210757a43ecff55a5c
🍃 Generated commit 4b15cfe98360d07c8c1ecf4815a6a7f5a28d0a3e
🌲 Generated branch generated/fix/save-rule-response
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
go 1633
javascript 1607
php 1405
csharp 1321
python 1087
java 1013
ruby 846
swift 749

Copy link
Contributor

@Fluf22 Fluf22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch !

@shortcuts shortcuts enabled auto-merge (squash) November 26, 2024 16:36
@shortcuts shortcuts merged commit afd94fa into main Nov 26, 2024
28 checks passed
@shortcuts shortcuts deleted the fix/save-rule-response branch November 26, 2024 16:52
algolia-bot added a commit that referenced this pull request Nov 26, 2024
algolia-bot added a commit to algolia/algoliasearch-client-csharp that referenced this pull request Nov 26, 2024
algolia-bot added a commit to algolia/algoliasearch-client-dart that referenced this pull request Nov 26, 2024
algolia-bot added a commit to algolia/algoliasearch-client-go that referenced this pull request Nov 26, 2024
algolia-bot added a commit to algolia/algoliasearch-client-java that referenced this pull request Nov 26, 2024
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Nov 26, 2024
algolia-bot added a commit to algolia/algoliasearch-client-kotlin that referenced this pull request Nov 26, 2024
algolia-bot added a commit to algolia/algoliasearch-client-php that referenced this pull request Nov 26, 2024
algolia-bot added a commit to algolia/algoliasearch-client-python that referenced this pull request Nov 26, 2024
algolia-bot added a commit to algolia/algoliasearch-client-ruby that referenced this pull request Nov 26, 2024
algolia-bot added a commit to algolia/algoliasearch-client-scala that referenced this pull request Nov 26, 2024
algolia-bot added a commit to algolia/algoliasearch-client-swift that referenced this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants