Skip to content

feat(clients): allow batch size on objects helper [skip-bc] #4172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Nov 27, 2024

Conversation

shortcuts
Copy link
Member

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DI-3249

Changes included:

make objects helper more configurable by allowing batch_size

@shortcuts shortcuts self-assigned this Nov 27, 2024
@shortcuts shortcuts requested a review from a team as a code owner November 27, 2024 11:28
@shortcuts shortcuts requested review from Fluf22 and millotp November 27, 2024 11:28
@shortcuts shortcuts marked this pull request as draft November 27, 2024 11:28
@algolia-bot
Copy link
Collaborator

algolia-bot commented Nov 27, 2024

✔️ Code generated!

Name Link
🪓 Triggered by d849ff1269084ab6fa32c4e467cef697c86b1ee5
🍃 Generated commit aff94b1b543641c680eb2d50bdcd254f42e0e527
🌲 Generated branch generated/feat/browse-batch-size
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
go 1661
javascript 1654
php 1447
csharp 1415
java 1119
python 1072
ruby 808
swift 742

@shortcuts shortcuts changed the title feat(clients): allow batch size on objects helper feat(clients): allow batch size on objects helper [skip-bc] Nov 27, 2024
@shortcuts shortcuts marked this pull request as ready for review November 27, 2024 12:51
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

très joli

@shortcuts shortcuts merged commit 2325c61 into main Nov 27, 2024
28 checks passed
@shortcuts shortcuts deleted the feat/browse-batch-size branch November 27, 2024 21:02
algolia-bot added a commit that referenced this pull request Nov 29, 2024
…generated) [skip ci]

Co-authored-by: Clément Vannicatte <[email protected]>
algolia-bot added a commit to algolia/algoliasearch-client-csharp that referenced this pull request Nov 29, 2024
algolia-bot added a commit to algolia/algoliasearch-client-java that referenced this pull request Nov 29, 2024
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Nov 29, 2024
algolia-bot added a commit to algolia/algoliasearch-client-kotlin that referenced this pull request Nov 29, 2024
algolia-bot added a commit to algolia/algoliasearch-client-php that referenced this pull request Nov 29, 2024
algolia-bot added a commit to algolia/algoliasearch-client-python that referenced this pull request Nov 29, 2024
algolia-bot added a commit to algolia/algoliasearch-client-ruby that referenced this pull request Nov 29, 2024
algolia-bot added a commit to algolia/algoliasearch-client-scala that referenced this pull request Nov 29, 2024
algolia-bot added a commit to algolia/algoliasearch-client-swift that referenced this pull request Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants