Skip to content

chore: use vite for browser playground [skip-bc] #4194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Dec 4, 2024

Conversation

shortcuts
Copy link
Member

🧭 What and Why

🎟 JIRA Ticket: -

Changes included:

use vite for browser playground, because it's easier to use and it seems to work with the workspaces, it also allows a build from the CI

@shortcuts shortcuts self-assigned this Dec 3, 2024
@algolia-bot
Copy link
Collaborator

algolia-bot commented Dec 3, 2024

✔️ Code generated!

Name Link
🪓 Triggered by f4a915bcd57f4e4b06bec82dd0ccfe5746a04a82
🍃 Generated commit 3d0aa8213194f17e11cf21800a83c32a33857a03
🌲 Generated branch generated/chore/vite-playground-browser
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
go 1658
javascript 1602
php 1485
csharp 1369
java 1133
python 1097
ruby 874
swift 712

@shortcuts shortcuts changed the title chore: use vite for browser playground chore: use vite for browser playground [skip-bc] Dec 3, 2024
@shortcuts shortcuts marked this pull request as ready for review December 3, 2024 13:55
@shortcuts shortcuts requested a review from a team as a code owner December 3, 2024 13:55
Comment on lines +14 to +17
"instantsearch.css": "^8.5.1",
"react": "^18.3.1",
"react-dom": "^18.3.1",
"react-instantsearch": "^7.13.8"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i've purposely kept that so that lock refresh validates with new versions

Copy link

github-actions bot commented Dec 3, 2024

@shortcuts shortcuts enabled auto-merge (squash) December 3, 2024 15:06
millotp
millotp previously approved these changes Dec 4, 2024
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@shortcuts shortcuts merged commit e9a6c24 into main Dec 4, 2024
28 checks passed
@shortcuts shortcuts deleted the chore/vite-playground-browser branch December 4, 2024 10:11
algolia-bot added a commit that referenced this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants