Skip to content

fix(ruby): handle unknown attributes in index_exists #4231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Dec 11, 2024

🧭 What and Why

This should fix the workaround in https://github.com/algolia/AlgoliaWeb/pull/23088, if we encounter a parsing error we know the index exist and can return true.

@millotp millotp requested a review from a team as a code owner December 11, 2024 14:18
@millotp millotp requested review from Fluf22 and shortcuts December 11, 2024 14:18
@algolia-bot
Copy link
Collaborator

algolia-bot commented Dec 11, 2024

✔️ Code generated!

Name Link
🪓 Triggered by 423a212f5de9ae6c881a1e870f82660247592492
🍃 Generated commit 53baaefea6115ac894af863097c4466ff30cc06a
🌲 Generated branch generated/fix/ruby-index-exists
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
ruby 870

Copy link
Contributor

@Fluf22 Fluf22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@millotp millotp merged commit 3f5ceb5 into main Dec 11, 2024
12 checks passed
@millotp millotp deleted the fix/ruby-index-exists branch December 11, 2024 14:34
algolia-bot added a commit that referenced this pull request Dec 11, 2024
algolia-bot added a commit to algolia/algoliasearch-client-ruby that referenced this pull request Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants