fix(ruby): Set default hits_per_page for SearchClient#browse_objects using accessor #4253
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
SearchClient#browse_objects is attempting to set a default
hits_per_page
value onbrowse_params
using[]
syntax, but Search::BrowseParamsObject doesn't implement the[]
method so any call to browse_objects using either the default or a custom BrowseParamsObject param throws an error.Changes included:
attr_accessor
in BrowseParamsObject to set the default value on the provided BrowseParamsObject param.