Skip to content

feat(specs): add with transformation helpers #4931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 4, 2025

Conversation

shortcuts
Copy link
Member

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DI-3879

Changes included:

This pr adds the saveObjectsWithTransformation and partialUpdateObjectsWithTransformation helpers to the spec, as well as moving some of the types to the common directory

I've scoped it under ingestion, which makes it a bit cleaner to navigate it, might as well do it for search in some next iteration

@shortcuts shortcuts self-assigned this Jun 3, 2025
@shortcuts shortcuts requested a review from a team as a code owner June 3, 2025 15:09
@shortcuts shortcuts requested review from morganleroi and Fluf22 June 3, 2025 15:09
@algolia-bot
Copy link
Collaborator

algolia-bot commented Jun 3, 2025

✔️ Code generated!

Name Link
🪓 Triggered by 5cc9f2372126382b64deaec13dfba12dd73c0c46
🍃 Generated commit 144ced5ab715cc38d443f3701ff38903b154eb87
🌲 Generated branch generated/feat/specs-with-transformation-helpers
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
go 1752
javascript 1615
php 1527
csharp 1357
java 1081
python 1047
ruby 847
swift 388
scala 23

Copy link
Contributor

@morganleroi morganleroi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Insane.

@shortcuts shortcuts requested a review from morganleroi June 4, 2025 14:43
Copy link
Contributor

@morganleroi morganleroi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@shortcuts shortcuts enabled auto-merge (squash) June 4, 2025 14:52
@shortcuts shortcuts merged commit 835dacc into main Jun 4, 2025
28 checks passed
@shortcuts shortcuts deleted the feat/specs-with-transformation-helpers branch June 4, 2025 15:00
algolia-bot added a commit that referenced this pull request Jun 4, 2025
algolia-bot added a commit to algolia/algoliasearch-client-csharp that referenced this pull request Jun 4, 2025
algolia-bot added a commit to algolia/algoliasearch-client-dart that referenced this pull request Jun 4, 2025
algolia-bot added a commit to algolia/algoliasearch-client-go that referenced this pull request Jun 4, 2025
algolia-bot added a commit to algolia/algoliasearch-client-java that referenced this pull request Jun 4, 2025
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Jun 4, 2025
algolia-bot added a commit to algolia/algoliasearch-client-kotlin that referenced this pull request Jun 4, 2025
algolia-bot added a commit to algolia/algoliasearch-client-php that referenced this pull request Jun 4, 2025
algolia-bot added a commit to algolia/algoliasearch-client-python that referenced this pull request Jun 4, 2025
algolia-bot added a commit to algolia/algoliasearch-client-ruby that referenced this pull request Jun 4, 2025
algolia-bot added a commit to algolia/algoliasearch-client-scala that referenced this pull request Jun 4, 2025
algolia-bot added a commit to algolia/algoliasearch-client-swift that referenced this pull request Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants