Skip to content

test(clients): test more region param and timeouts #663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 10, 2022

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Jun 9, 2022

🧭 What and Why

Add a few more test for completeness.

🧪 Test

CI

@millotp millotp self-assigned this Jun 9, 2022
@netlify
Copy link

netlify bot commented Jun 9, 2022

Deploy Preview for api-clients-automation canceled.

Name Link
🔨 Latest commit 065c696
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/62a30329f5a7b40008fc16f1

@algolia-bot
Copy link
Collaborator

algolia-bot commented Jun 9, 2022

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@millotp millotp changed the title fix(tests): test more region param and timeouts fix(test): test more region param and timeouts Jun 9, 2022
@millotp millotp changed the title fix(test): test more region param and timeouts test(clients): test more region param and timeouts Jun 9, 2022
@millotp millotp requested review from a team, damcou and shortcuts and removed request for a team June 9, 2022 16:00
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!

damcou
damcou previously approved these changes Jun 10, 2022
Copy link
Contributor

@damcou damcou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking forward to see if everything passes on my PR :p

Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couldn't have been cleaner

@millotp millotp enabled auto-merge (squash) June 10, 2022 08:45
@millotp millotp merged commit ad27abc into main Jun 10, 2022
@millotp millotp deleted the fix/more-client-tests branch June 10, 2022 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants