feat(javascript): allow legacy signature for search method
#665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for api-clients-automation canceled.
|
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
shortcuts
requested review from
Haroenv,
a team,
eunjae-lee and
millotp
and removed request for
a team
shortcuts
force-pushed
the
feat/javascript-allow-legacy-search
branch
from
2f7f48d to
d827f95
Compare
shortcuts
force-pushed
the
feat/javascript-allow-legacy-search
branch
from
d827f95 to
ca56545
Compare
shortcuts
force-pushed
the
feat/javascript-allow-legacy-search
branch
from
ca56545 to
0d0450c
Compare
Ahaha sacrifices! |
Haroenv
reviewed
Jun 13, 2022
templates/javascript/api/operation/legacySearchCompatible/implementation.mustache
Show resolved
Hide resolved
Haroenv
previously approved these changes
Jun 14, 2022
millotp
approved these changes
Jun 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: https://algolia.atlassian.net/browse/APIC-528
Changes included:
As discussed during our tech syncs with the fx team, we've decided to support the legacy signature for the
searchmethod and handle the logic on our side.In this PR, we implement the logic in the
client-search,algoliasearchandalgoliasearch-litepackages.As
algoliasearchinherits of methods from theclient-searchpackage, andalgoliasearch-liteis a lighter copy of it, I've added tests in this client to ensure the alias works smoothly.🧪 Test
yarn workspace @experimental-api-clients-automation/algoliasearch testyarn workspace javascript-playground start:algoliasearch