Skip to content

chore(ci): make the artifacts dynamic #689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 16 commits into from
Closed

chore(ci): make the artifacts dynamic #689

wants to merge 16 commits into from

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Jun 14, 2022

🧭 What and Why

By making the artifacts download depends on the matrix, we have access to the data to remove the correct file and then apply the artifact, so the deleted files stays deleted and we don't need to push them manually anymore, cleaning the changes in PR.

Changes included:

  • Use the artifacts API from github
  • Use the matrix to delete the correct files before applying the zip
  • Remove deleted files from commit

🧪 Test

CI

@netlify
Copy link

netlify bot commented Jun 14, 2022

Deploy Preview for api-clients-automation canceled.

Name Link
🔨 Latest commit 1c26716
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/62a8a9490e9faa0009105b9e

@algolia-bot
Copy link
Collaborator

algolia-bot commented Jun 14, 2022

🔨 The codegen job will run at the end of the CI.

Make sure your last commit does not contain generated code, it will be automatically pushed by our CI.

@millotp
Copy link
Collaborator Author

millotp commented Jun 14, 2022

Not possible until actions/upload-artifact#53 is solved

@millotp millotp changed the title chore(ci): commit deleted files chore(ci): make the artifacts dynamic Jun 16, 2022
@millotp millotp self-assigned this Jun 20, 2022
@millotp millotp closed this Dec 26, 2023
@millotp millotp deleted the chore/delete-gen branch January 24, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants