fix(java): use batch and class in playground and doc #696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for api-clients-automation ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
millotp
requested review from
a team,
damcou and
shortcuts
and removed request for
a team
shortcuts
reviewed
Jun 15, 2022
shortcuts
reviewed
Jun 15, 2022
millotp
changed the title
algolia-bot
added a commit
to algolia/algoliasearch-client-java
that referenced
this pull request
Jun 15, 2022
algolia/api-clients-automation#696 Co-authored-by: Pierre Millot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
The JSON serializer Gson is quite shitty and it would be great to change to jackson before it's too late,
it cannot handle any form of HashMap or else it requires lots of custom code with heavy reflection.
Changes included:
🧪 Test
yarn docker playground java search