Skip to content

docs(php): Add remaining guides #699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 17, 2022
Merged

docs(php): Add remaining guides #699

merged 5 commits into from
Jun 17, 2022

Conversation

damcou
Copy link
Contributor

@damcou damcou commented Jun 15, 2022 •
edited
Loading

🧭 What and Why

🎟 JIRA Ticket: APIC=-530

Changes included:

Remaining guides for PHP:

  • Add "Customized client usage"
  • Add "Wait for a task to finish"
  • Add "Copy or move an index"
  • Add migration guide for PHP

🧪 Test

  • Netlify

@damcou damcou self-assigned this Jun 15, 2022
@netlify
Copy link

netlify bot commented Jun 15, 2022 •
edited
Loading

✅ Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit af73a08
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/62ac3d0c5829c30009b113ff
😎 Deploy Preview https://deploy-preview-699--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Jun 15, 2022 •
edited
Loading

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@damcou damcou marked this pull request as ready for review June 15, 2022 15:44
@damcou damcou requested review from shortcuts and millotp June 15, 2022 15:44
@millotp
Copy link
Collaborator

millotp commented Jun 15, 2022

I don't really know what's wrong with netlify, is your branch up to date ?

@damcou
Copy link
Contributor Author

damcou commented Jun 16, 2022

I don't really know what's wrong with netlify, is your branch up to date ?

Should be good now !

millotp
millotp reviewed Jun 16, 2022
View reviewed changes
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good ! some small comments

@damcou damcou requested a review from millotp June 17, 2022 07:50
shortcuts
shortcuts reviewed Jun 17, 2022
View reviewed changes
@damcou damcou requested a review from shortcuts June 17, 2022 08:36
shortcuts
shortcuts approved these changes Jun 17, 2022
View reviewed changes
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@damcou damcou merged commit 108956e into main Jun 17, 2022
@damcou damcou deleted the docs/API-530/remaining-php-doc branch June 17, 2022 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shortcuts shortcuts shortcuts approved these changes

@millotp millotp Awaiting requested review from millotp

Assignees

@damcou damcou

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@damcou @algolia-bot @millotp @shortcuts