Skip to content

chore(ci): make pre-commit hook instant #702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 16, 2022
Merged

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Jun 15, 2022

🧭 What and Why

The git restore command can take multiple files as a parameter, this make the hook instant instead of a few seconds when we have hundreds of file.

🧪 Test

Delete all the generated files and make a commit, the print and unstage is instant.

@millotp millotp self-assigned this Jun 15, 2022
@netlify
Copy link

netlify bot commented Jun 15, 2022

Deploy Preview for api-clients-automation canceled.

Name Link
🔨 Latest commit aac347e
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/62aa0d12a75207000a182966

@millotp millotp assigned millotp and unassigned millotp Jun 15, 2022
@millotp millotp requested review from a team, damcou and shortcuts and removed request for a team June 15, 2022 16:34
@algolia-bot
Copy link
Collaborator

algolia-bot commented Jun 15, 2022

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

Copy link
Contributor

@damcou damcou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks indeed way faster 🚀

@millotp millotp merged commit 750523b into main Jun 16, 2022
@millotp millotp deleted the chore/fast-pre-commit branch June 16, 2022 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants