Skip to content

feat(java): enable custom level debug APIC-535 #705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 16, 2022
Merged

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Jun 15, 2022

🧭 What and Why

🎟 JIRA Ticket: APIC-535

Enable different level of debug for the java client, and document it.

🧪 Test

yarn docker playground java search

@millotp millotp self-assigned this Jun 15, 2022
@millotp millotp requested review from a team, damcou and shortcuts and removed request for a team June 15, 2022 19:27
@netlify
Copy link

netlify bot commented Jun 15, 2022

Deploy Preview for api-clients-automation canceled.

Name Link
🔨 Latest commit df1a3d4
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/62ab037eb85d050008a3edd7

@algolia-bot
Copy link
Collaborator

algolia-bot commented Jun 15, 2022

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@@ -16,9 +16,9 @@ public interface Requester {
/**
* Enable/disable debugging for this API client.
*
* @param debugging To enable (true) or disable (false) debugging
* @param level LogLevel the level of log to output
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

best comment ever

Copy link
Contributor

@damcou damcou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, maybe I should think of something similar for the PHP one.

Base automatically changed from chore/fast-pre-commit to main June 16, 2022 10:17
@millotp millotp enabled auto-merge (squash) June 16, 2022 10:20
@millotp millotp merged commit 14190d7 into main Jun 16, 2022
@millotp millotp deleted the feat/java-logger branch June 16, 2022 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants