Skip to content

fix(scripts): correctly update config file, push playground #725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 20, 2022
Merged

fix(scripts): correctly update config file, push playground #725

merged 1 commit into from
Jun 20, 2022

Conversation

shortcuts
Copy link
Member

🧭 What and Why

🎟 JIRA Ticket: -

Changes included:

  • Allow the release process to push every files that have been modified (playground were missing)
  • Delete scripts related fields from the final openapitools.json config
    • the packageName only exists for our internal use, we don't need to expose it in the final file

🧪 Test

CI :D

@shortcuts shortcuts requested a review from damcou June 20, 2022 16:00
@shortcuts shortcuts self-assigned this Jun 20, 2022
@netlify
Copy link

netlify bot commented Jun 20, 2022 •
edited
Loading

✅ Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit 736bc40
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/62b099b6f1cfd8000a1a6ac7
😎 Deploy Preview https://deploy-preview-725--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@shortcuts shortcuts enabled auto-merge (squash) June 20, 2022 16:01
@algolia-bot
Copy link
Collaborator

algolia-bot commented Jun 20, 2022 •
edited
Loading

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@shortcuts shortcuts disabled auto-merge June 20, 2022 16:02
damcou
damcou approved these changes Jun 20, 2022
View reviewed changes
Copy link
Contributor

@damcou damcou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shortcuts shortcuts enabled auto-merge (squash) June 20, 2022 16:04
@shortcuts shortcuts merged commit 24b960d into main Jun 20, 2022
@shortcuts shortcuts deleted the fix/update-api-scripts branch June 20, 2022 16:14
@shortcuts shortcuts mentioned this pull request Jun 21, 2022
Closed
@damcou damcou mentioned this pull request Jun 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damcou damcou damcou approved these changes

Assignees

@shortcuts shortcuts

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shortcuts @algolia-bot @damcou